Re: [PATCH] firmware: stratix10-svc: Fix IS_ERR() vs NULL check in stratix10_svc_drv_probe()

From: cuigaosheng
Date: Mon Nov 14 2022 - 06:16:01 EST


How was this found and tested?

Thanks for taking time to review this patch.
I found this through the cocci script, I made the patch based on the code logic,
but I have not tested it due to the lack of hardware devices.

On 2022/11/14 15:24, Greg KH wrote:
On Mon, Nov 14, 2022 at 10:59:21AM +0800, Gaosheng Cui wrote:
The svc_create_memory_pool() returns an ERR_PTR() on failure, we should use
IS_ERR() to check the return value, and return it on failure.
How was this found and tested?

thanks,

greg k-h
.