Re: [PATCH v2 02/13] dt-bindings: usb: Add NVIDIA Tegra234 XUSB host controller binding

From: Jon Hunter
Date: Mon Nov 14 2022 - 05:57:33 EST



On 11/11/2022 17:32, Rob Herring wrote:
On Fri, Nov 11, 2022 at 02:38:21PM +0000, Jon Hunter wrote:

On 11/11/2022 13:30, Rob Herring wrote:

On Fri, 11 Nov 2022 18:14:58 +0800, Wayne Chang wrote:
Add device-tree binding documentation for the XUSB host controller present
on Tegra234 SoC. This controller supports the USB 3.1 specification.

Signed-off-by: Wayne Chang <waynec@xxxxxxxxxx>
---
V1 -> V2: new change for adding nvidia,tegra234-xusb.yaml
.../bindings/usb/nvidia,tegra234-xusb.yaml | 159 ++++++++++++++++++
1 file changed, 159 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.yaml


My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.example.dts:36.27-28 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bindings/usb/nvidia,tegra234-xusb.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1492: dt_binding_check] Error 2

This compiles fine on top of -next. We are just missing the change that
populates the required definitions.

Where exactly is that mentioned in the commit msg?

It is mentioned in the cover-letter.

No maintainer can take patches which apply against linux-next, so not a
good dependency to mention either.

Yes understand, I was just trying to indicate that there is a known dependency here that we need to handle.

Jon

--
nvpublic