Re: [GIT PULL] hotfixes for 6.1-rc5

[Geert Uytterhoeven]

Hi Liam,

On Sat, Nov 12, 2022 at 2:25 AM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> Linus, please merge this batch of hotfixes.
>
> Thanks.
>
> The following changes since commit f0c4d9fc9cc9462659728d168387191387e903cc:
>
>   Linux 6.1-rc4 (2022-11-06 15:07:11 -0800)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm tags/mm-hotfixes-stable-2022-11-11
>
> for you to fetch changes up to 436fa4a699bcd1c368bea9199e22b0a1b9cf9e0f:
>
>   docs: kmsan: fix formatting of "Example report" (2022-11-08 15:57:25 -0800)
>
> ----------------------------------------------------------------
> 22 hotfixes.  8 are cc:stable and the remainder address issues which were
> introduced post-6.0 or which aren't considered serious enough to justify a
> -stable backport.
>
> ----------------------------------------------------------------

> Liam Howlett (5):
>       maple_tree: remove pointer to pointer use in mas_alloc_nodes()
>       maple_tree: mas_anode_descend() clang-analyzer cleanup
>       maple_tree: reorganize testing to restore module testing

Thanks for your patch, which is now commit 120b116208a08772
("maple_tree: reorganize testing to restore module testing")
in v6.1-rc5.

    +config TEST_MAPLE_TREE
    +       select DEBUG_MAPLE_TREE
    +       tristate "Test the Maple Tree code at runtime"
    +

There are two problems with this:

  1. If CONFIG_DEBUG_KERNEL=n:

        WARNING: unmet direct dependencies detected for DEBUG_MAPLE_TREE
          Depends on [n]: DEBUG_KERNEL [=n]
          Selected by [m]:
          - TEST_MAPLE_TREE [=m] && RUNTIME_TESTING_MENU [=y]

  2. IMHO test code should not silently enable additional features, as
     it prevents providing a test module for a production system,
     without having any other impact on that system.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds