Re: [net-next PATCH 0/9] CN10KB MAC block support

[Hariprasad Kelam]

On Fri, Nov 11, 2022 at 09:12:35PM -0800, Jakub Kicinski wrote:
> On Sat, 12 Nov 2022 10:01:32 +0530 Hariprasad Kelam wrote:
> > The nextgen silicon CN10KB supports new MAC block RPM2 and has a 
> > variable number of LMACS. This series of patches defines new mac_ops 
> > and configures csrs specific to new MAC.
> > 
> > Defines new mailbox support to Reset LMAC stats, read FEC stats and 
> > set Physical state such that PF netdev can use mailbox support to 
> > use the features.
> > 
> > Extends debugfs support for MAC block to show dropped packets by 
> > DMAC filters and show FEC stats
> 
> I personally see no reason for us to keep merging your AF patches.
> Upstream is for working together and there is no synergy between your 
> code, other drivers and the user APIs we build. Why not just keep it 
> out of tree?

Yes, see my comment about the ethtool .get_fec_stats. Maybe it is there, hidden amongst all the code, but it is not obvious.

If you do want to stay in tree, may i suggest you move all your statistics in your debugfs to official kernel APIs, and then remove them from debugfs. This might require you work with the community to extend the current APIs, which is the synergy thing Jakub is taking about.

	Andrew


This patch series adds two debugfs entries, one for FEC stats and other to show "Dropped packets by DMAC filters".

For FEC stats will remove debugfs entry and integrate to ethtool API in the next version.

For  "Dropped packets by DMAC filters" did not find any equivalent APIs, so will keep it as is.