Re: [PATCH v2 2/4] regmap-irq: Add handle_mask_sync() callback

[William Breathitt Gray]

On Sun, Nov 13, 2022 at 02:42:49PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 10, 2022 at 08:55:51PM -0500, William Breathitt Gray wrote:
> > Provide a public callback handle_mask_sync() that drivers can use when
> > they have more complex IRQ masking logic. The default implementation is
> > regmap_irq_handle_mask_sync(), used if the chip doesn't provide its own
> > callback.
> 
> ...
> 
> > + * @handle_mask_sync: Callback used to handle IRQ mask syncs. The index will be
> > + *		      in the range [0, num_regs[
> 
> Not sure if it's a typo ([ vs. ]), but if you want to say "not including the
> last", use mathematical notation, i.e. "[0, num_regs)".

I was following the convention used in the @get_irq_reg description, but
I agree that mathematical notation would be much clearer.

William Breathitt Gray

Attachment: signature.asc
Description: PGP signature