Re: [PATCH v2 1/2] dt-bindings: iio: addac: add AD74115

From: Jonathan Cameron
Date: Sat Nov 12 2022 - 10:28:34 EST



> >
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > + description: |
> > > + Conversion range for ADC conversion 2.
> > > + 0 - 0V to 12V
> > > + 1 - -12V to +12V
> > > + 2 - -2.5V to +2.5V
> > > + 3 - -2.5V to 0V
> > > + 4 - 0V to 2.5V
> > > + 5 - 0V to 0.625V
> > > + 6 - -104mV to +104mV
> > > + 7 - 0V to 12V
> >
> > For a lot of similar cases we handle these numerically to give
> > a human readable dts. Is there a strong reason not to do so here (in mv)
> >
>
> I used this approach mostly because it maps dirrectly to register values
> and because it's easier to parse. dts isn't exactly nice at handling
> negative values. I can switch it to mv array if you insist.

We have quite a few existing cases of
adi,[output-]range-microvolt so it would be good to copy that style here.

>
> >
> > > + minimum: 0
> > > + maximum: 7
> > > + default: 0
> > > +