Re: [PATCH 19/22] phy: qcom-qmp-combo: clean up device-tree parsing

From: Dmitry Baryshkov
Date: Sat Nov 12 2022 - 02:48:11 EST


On 11/11/2022 11:56, Johan Hovold wrote:
Since the QMP driver split there will be precisely two child nodes so
drop the obsolete iteration construct.

While at it, drop the verbose error logging that would have been printed
also on probe deferrals.

Note that there is no need to check if there are additional child nodes
(the kernel is not a devicetree validator), but let's return an error if
either child node is missing.

Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
---
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 82 ++++++++---------------
1 file changed, 28 insertions(+), 54 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

--
With best wishes
Dmitry