Re: [PATCH v7 18/28] media: sun6i-csi: Introduce format match structure, list and helper

From: Sakari Ailus
Date: Fri Nov 11 2022 - 05:22:27 EST


On Fri, Nov 11, 2022 at 12:18:14PM +0200, Sakari Ailus wrote:
> Hi Paul,
>
> On Thu, Nov 03, 2022 at 05:31:03PM +0100, Paul Kocialkowski wrote:
> > Introduce a list of mbus/pixel format combinations that need an exact
> > match between the two sides. This is the case when using raw input
> > configuration. The list will be used to replace the
> > sun6i_csi_is_format_supported combinatory helper.
>
> This patch introduces an unused function which generates a compiler warning
> that is now treated as an error.
>
> I'll squash this to the following patch that uses the function. I think the
> commit message will do as-is.

Ok, maybe the helper actually should be mentioned. I used this:

Rework the capture link validate implementation with actual logic that
reflects the possibilities of the device instead of the combinatory helper
functions, using the added match list helper
sun6i_csi_is_format_supported() when needed. Remove the previous dedicated
helper.

--
Sakari Ailus