Re: [PATCH v3] ARM: dts: imx: e60k02: Add touchscreen

[Andreas Kemnade]

Hi Marco,

On Fri, 11 Nov 2022 10:12:23 +0100
Marco Felsch <m.felsch@xxxxxxxxxxxxxx> wrote:

> Hi Andreas,
> 
> On 22-11-09, Andreas Kemnade wrote:
> > On Wed, 9 Nov 2022 10:23:50 +0100
> > Marco Felsch <m.felsch@xxxxxxxxxxxxxx> wrote:
> >   
> > > Hi Andreas,
> > > 
> > > On 22-11-08, Andreas Kemnade wrote:  
> > > > Add the touchscreen now, since the driver is available.
> > > > 
> > > > Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> > > > ---
> > > > Changes in v3: no phandles pointing from dtsi to dts    
> > > 
> > > Thanks for this change...
> > >   
> > > > Changes in v2: fix pinmux naming
> > > > 
> > > >  arch/arm/boot/dts/e60k02.dtsi              |  9 ++++++++-
> > > >  arch/arm/boot/dts/imx6sl-tolino-shine3.dts | 12 ++++++++++++
> > > >  arch/arm/boot/dts/imx6sll-kobo-clarahd.dts | 12 ++++++++++++
> > > >  3 files changed, 32 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/arch/arm/boot/dts/e60k02.dtsi
> > > > b/arch/arm/boot/dts/e60k02.dtsi index 935e2359f8df..99091db3ab2a
> > > > 100644 --- a/arch/arm/boot/dts/e60k02.dtsi
> > > > +++ b/arch/arm/boot/dts/e60k02.dtsi
> > > > @@ -104,7 +104,14 @@ &i2c2 {
> > > >  	clock-frequency = <100000>;
> > > >  	status = "okay";
> > > >  
> > > > -	/* TODO: CYTTSP5 touch controller at 0x24 */
> > > > +	cyttsp5: touchscreen@24 {
> > > > +		compatible = "cypress,tt21000";
> > > > +		reg = <0x24>;
> > > > +		interrupt-parent = <&gpio5>;
> > > > +		interrupts = <6 IRQ_TYPE_EDGE_FALLING>;
> > > > +		reset-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> > > > +		vdd-supply = <&ldo5_reg>;
> > > > +	};    
> > > 
> > > but we still have a cross-reference to the .dtsi file here. Therefore
> > > I said to move the interrupt/reset-gpio into the dts file too. I know
> > > this is a kind of a nitpick but I really don't like such
> > > cross-references.
> > >   
> > hmm. &gpio5 references to imx6sl[l].dtsi, not dts, so what is the
> > problem here?  
> 
> Sorry for the missunderstanding, I didn't mean the phandle. I mean the
> mux setting which is done in the dts right? I'm just not a fan of
> muxing pins in one file an using those 'assumptions' in others. Except
> for platforms like the imx8mm-evk which is exactly the same hardware and
> only differs in the RAM they used. But you have two different platforms
> right?
> 
Same board, same PCB marking, the only spotted difference is the name on the
case and the SoC (which is pin-compatible, so GPIOs will be all the same).

In the case of different hardware platforms I would understand your
ruffled feathers.

Regards,
Andreas