Re: [PATCH] soc: mediatek: Add deprecated compatible to mmsys

[Matthias Brugger]

On 10/11/2022 16:03, AngeloGioacchino Del Regno wrote:
> Il 10/11/22 13:02, matthias.bgg@xxxxxxxxxx ha scritto:
> > From: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> >
> > For backward compatibility we add the deprecated compatible.
> >
> > Signed-off-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>
>
> Hello Matthias,
>
> You forgot to advertise that this commit depends on [1]... and I'm afraid
> that you have to push a v2 anyway, because...

Well yes I based it against mediateks for-next branch, sorry for the confusion.

> > ---
> >   drivers/soc/mediatek/mtk-mmsys.c | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
> > index ba2e79b26993b..47106f557c574 100644
> > --- a/drivers/soc/mediatek/mtk-mmsys.c
> > +++ b/drivers/soc/mediatek/mtk-mmsys.c
> > @@ -303,6 +303,10 @@ static const struct of_device_id of_match_mtk_mmsys[] = {
> >           .compatible = "mediatek,mt8192-mmsys",
> >           .data = &mt8192_mmsys_driver_data,
> >       },
> > +    {    /* deprecated compatible */
> > +        .compatible = "mediatek,mt8195-mmsys",
> > +        .data = &mt8195_mmsys_match_data,
>
> ...mt8195_mmsys_match_data doesn't exist anymore after [1], so this should be
>
>          .data = &mt8195_vdosys0_driver_data,

Of course, should have compile tested at least. /o\

Regards,
Matthias

> [1]: https://patchwork.kernel.org/project/linux-mediatek/list/?series=681097
>
> Cheers,
> Angelo