Re: [PATCH v6 1/2] soc: loongson: add GUTS driver for loongson-2 platforms

From: Yinbo Zhu
Date: Fri Nov 11 2022 - 01:08:22 EST




在 2022/11/9 下午11:08, Arnd Bergmann 写道:
On Wed, Nov 9, 2022, at 14:50, Huacai Chen wrote:
On Wed, Nov 9, 2022 at 7:06 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
On Wed, Nov 9, 2022, at 11:15, Linus Walleij wrote:
On Wed, Nov 9, 2022 at 11:03 AM Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> wrote:

Hi maintainer,

This patch I had verified that base on mainline 6.1-rc3 tree, it is
okay, if no other issue, please you help me merge it to upstream.

Aren't these loongarch maintainers listed in MAINTAINERS able to
merge this? Certainly Huacai can merge stuff to drivers/soc as
need be. drivers/soc is a bit shared between different archs.

I'm generally happy to keep an eye on stuff in drivers/soc/ across
architectures and merge it through the soc tree, especially for
new platforms, but merging this through the loongarch tree works
as well.
So drivers/soc is similar to drivers/platform that can be merged
through corresponding architecture trees?

Right, I think in both cases, there is no top-level subsystem
maintainer, but the rules are specific to the second-level
hierarchy: most parts of drivers/platform/ happen to go
through the x86 platform maintainer trees, and for drivers/soc
we merge most stuff through the soc tree, but a few parts
of each have different maintainers.

Since the driver was already sent to soc@xxxxxxxxxx, I can
simply pick it up through patchwork[1] when I do my next round
of merges. I'll leave this up to Huacai Chen and WANG Xuerui,
let me know if you prefer to merge it through the loongarch
tree.
I'm happy that this series be merged through your linux-arch tree, but
if it is better (I'm not sure which is better) to go through loongarch
tree I can also merge it later. However, I have some comments about
this version. :)

I would prefer the soc tree, and will just apply the
patches from Yinbo Zhu directly this time as I already
have them in my queue. If there are more than a few
drivers/soc/loongarch/ patches in the future, maybe you can
pick them up into a separate branch and forward those
to soc@xxxxxxxxxx.

Note that I have two separate roles here: I have the
asm-generic tree that I maintain for patches to
include/asm-generic as well as the occasional new
architecture review as I did for loongarch.

The other one is the group maintained soc tree that
is mainly for Arm device tree files, but also contains
soc specific code (arch/arm/mach-*), defconfig files,
drivers (drivers/{soc,firmware,memory,reset}). This is
now extended to arch/riscv and occasionally other
architectures as well, so drivers/soc/loongson fits
well in here.

Arnd
Hi Arnd Bergmann,

I had add v7 version patch and please help check and merge it.
in addition, I don't find apprioate branch in your tree for test, so
my patch was tested that base on 6.1-rc3 master branch.

BRs,
YinBo.