Re: Coverity: zram_recompress(): OVERRUN

From: Sergey Senozhatsky
Date: Thu Nov 10 2022 - 19:26:52 EST


On (22/11/10 08:47), coverity-bot wrote:
> *** CID 1527270: (OVERRUN)
> drivers/block/zram/zram_drv.c:1727 in zram_recompress()
> 1721 zstrm = zcomp_stream_get(zram->comps[prio]);
> 1722 src = kmap_atomic(page);
> 1723 ret = zcomp_compress(zstrm, src, &comp_len_new);
> 1724 kunmap_atomic(src);
> 1725
> 1726 if (ret) {
> vvv CID 1527270: (OVERRUN)
> vvv Overrunning array "zram->comps" of 4 8-byte elements at element index 4 (byte offset 39) using index "prio" (which evaluates to 4).

Hmm... I don't really see how prio can evaluate to 4.