Re: [PATCH linux-next] ACPI: sysfs: use sysfs_emit() to instead of scnprintf()

From: Rafael J. Wysocki
Date: Thu Nov 10 2022 - 14:26:21 EST


On Wed, Nov 9, 2022 at 2:25 PM <yang.yang29@xxxxxxxxxx> wrote:
>
> From: Xu Panda <xu.panda@xxxxxxxxxx>
>
> Replace scnprintf() with sysfs_emit() to simplify the code.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Xu Panda <xu.panda@xxxxxxxxxx>
> Signed-off-by: Yang Yang <yang.yang29@xxxxxxx>
> ---
> drivers/acpi/sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c
> index 2d81c742e4d2..e6fe1c02a138 100644
> --- a/drivers/acpi/sysfs.c
> +++ b/drivers/acpi/sysfs.c
> @@ -198,7 +198,7 @@ static int param_set_trace_method_name(const char *val,
>
> static int param_get_trace_method_name(char *buffer, const struct kernel_param *kp)
> {
> - return scnprintf(buffer, PAGE_SIZE, "%s\n", acpi_gbl_trace_method_name);
> + return sysfs_emit(buffer, "%s\n", acpi_gbl_trace_method_name);
> }
>
> static const struct kernel_param_ops param_ops_trace_method = {
> --

Applied as 6.2 material, thanks!