Re: [PATCH] ASoC: sgtl5000: Reset the CHIP_CLK_CTRL reg on remove

[Fabio Estevam]

On Thu, Nov 10, 2022 at 4:06 PM Detlev Casanova
<detlev.casanova@xxxxxxxxxxxxx> wrote:
>
> Since commit bf2aebccddef ("ASoC: sgtl5000: Fix noise on shutdown/remove"),
> the device power control registers are reset when the driver is
> removed/shutdown.
>
> This is an issue when the device is configured to use the PLL clock. The
> device will stop responding if it is still configured to use the PLL
> clock but the PLL clock is powered down.
>
> When rebooting linux, the probe function will show:
> sgtl5000 0-000a: Error reading chip id -11
>
> Make sure that the CHIP_CLK_CTRL is reset to its default value before
> powering down the device.
>
> Fixes: bf2aebccddef ("ASoC: sgtl5000: Fix noise on shutdown/remove")
> Signed-off-by: Detlev Casanova <detlev.casanova@xxxxxxxxxxxxx>

Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>