Re: [PATCH v3 tty-next 1/3] 8250: microchip: pci1xxxx: Add driver for quad-uart support.

[Greg KH]

On Thu, Nov 10, 2022 at 05:18:46PM +0000, Kumaravel.Thiagarajan@xxxxxxxxxxxxx wrote:
> > -----Original Message-----
> > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Sent: Wednesday, November 9, 2022 5:31 PM
> > To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@xxxxxxxxxxxxx>
> > Subject: Re: [PATCH v3 tty-next 1/3] 8250: microchip: pci1xxxx: Add driver for
> > quad-uart support.
> >  
> > On Mon, Nov 07, 2022 at 06:15:15PM +0530, Kumaravel Thiagarajan wrote:
> > > +++ b/drivers/tty/serial/8250/8250_pcilib.c
> > > @@ -0,0 +1,31 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/* Microchip pci1xxxx 8250 library. */
> > 
> > Better name and a copyright line?
> Yes Greg. I think "8250 PCI library" would be the correct name. Is that fine?

That would be good as obviously it's not a microchip-only thing here.

> Regarding the copyright, we moved the "setup_port" function from 8250_pci.c to this new file.
> Can I use the same copyright statement from 8250_pci.c "Copyright (C) 2001 Russell King, All Rights Reserved."?

Yes, that would be good.

thanks,

greg k-h