Re: [PATCH] blkdev: make struct block_device_operations.devnode() take a const *

From: Greg Kroah-Hartman
Date: Thu Nov 10 2022 - 12:24:05 EST


On Wed, Nov 09, 2022 at 12:41:09PM -0700, Jens Axboe wrote:
> On 11/9/22 7:48 AM, Greg Kroah-Hartman wrote:
> > The devnode() callback in struct block_device_operations should not be
> > modifying the device that is passed into it, so mark it as a const * and
> > propagate the function signature changes out into the one subsystem that
> > actually uses this callback.
> >
> > Cc: linux-block@xxxxxxxxxxxxxxx
> > Cc: Jens Axboe <axboe@xxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > ---
> >
> > Jens, I have some dependent kobject/driver core changes that require
> > this change in the works. Can I take this through the driver core tree
> > for 6.2-rc1?
>
> Yeah go ahead, you can add my:
>
> Acked-by: Jens Axboe <axboe@xxxxxxxxx>

Thanks!