Coverity: nv50_sor_atomic_enable(): Memory - corruptions

From: coverity-bot
Date: Thu Nov 10 2022 - 11:49:25 EST


Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20221110 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

Wed Nov 9 08:22:02 2022 +1000
813443721331 ("drm/nouveau/disp: move DP link config into acquire")

Coverity reported the following:

*** CID 1527269: Memory - corruptions (OVERRUN)
drivers/gpu/drm/nouveau/dispnv50/disp.c:1619 in nv50_sor_atomic_enable()
1613 lvds_8bpc = true;
1614 }
1615
1616 nvif_outp_acquire_lvds(&nv_encoder->outp, lvds_dual, lvds_8bpc);
1617 break;
1618 case DCB_OUTPUT_DP:
vvv CID 1527269: Memory - corruptions (OVERRUN)
vvv Overrunning array "(*nv_encoder).dp.dpcd" of 15 bytes by passing it to a function which accesses it at byte offset 15.
1619 nvif_outp_acquire_dp(&nv_encoder->outp, nv_encoder->dp.dpcd, 0, 0, hda, false);
1620 depth = nv50_dp_bpc_to_depth(asyh->or.bpc);
1621
1622 if (nv_encoder->outp.or.link & 1)
1623 proto = NV887D_SOR_SET_CONTROL_PROTOCOL_DP_A;
1624 else

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx>
Addresses-Coverity-ID: 1527269 ("Memory - corruptions")
Fixes: 813443721331 ("drm/nouveau/disp: move DP link config into acquire")

Thanks for your attention!

--
Coverity-bot