Re: [PATCH v6 06/10] pwm: dwc: split pci out of core driver

[Ben Dooks]

On 10/11/2022 15:29, Uwe Kleine-König wrote:
> On Thu, Oct 20, 2022 at 04:16:06PM +0100, Ben Dooks wrote:
> > Moving towards adding non-pci support for the driver, move the pci
> > parts out of the core into their own module. This is partly due to
> > the module_driver() code only being allowed once in a module and also
> > to avoid a number of #ifdef if we build a single file in a system
> > without pci support.
> >
> > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxx>
> > ---
> > v6:
> >   - put DWC_PERIOD_NS back to avoid bisect issues
> > v4:
> >   - removed DWC_PERIOD_NS as not needed
> > ---
> >   drivers/pwm/Kconfig       |  14 +++-
> >   drivers/pwm/Makefile      |   1 +
> >   drivers/pwm/pwm-dwc-pci.c | 133 ++++++++++++++++++++++++++++++++
> >   drivers/pwm/pwm-dwc.c     | 158 +-------------------------------------
> >   drivers/pwm/pwm-dwc.h     |  58 ++++++++++++++
> >   5 files changed, 207 insertions(+), 157 deletions(-)
> >   create mode 100644 drivers/pwm/pwm-dwc-pci.c
> >   create mode 100644 drivers/pwm/pwm-dwc.h
> >
> > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> > index 3f3c53af4a56..a9f1c554db2b 100644
> > --- a/drivers/pwm/Kconfig
> > +++ b/drivers/pwm/Kconfig
> > @@ -175,15 +175,23 @@ config PWM_CROS_EC
> >   	  Controller.
> >   
> >   config PWM_DWC
> > -	tristate "DesignWare PWM Controller"
> > -	depends on PCI || COMPILE_TEST
> > +	tristate "DesignWare PWM Controller core"
> >   	depends on HAS_IOMEM
> >   	help
> > -	  PWM driver for Synopsys DWC PWM Controller attached to a PCI bus.
> > +	  PWM driver for Synopsys DWC PWM Controller.
>
> Currently pwm-dwc doesn't contain a driver but is only a library used by
> pwm-dwc-pci (and later the of driver). As such it doesn't make sense to
> be user-selectible, does it? 

I suppose the PWM_DWC should select the original driver an a new
PWM_DW_CORE should build the actual core driver.

--
Ben