Re: [PATCH net-next] rxrpc: Fix missing IPV6 #ifdef

From: David Howells
Date: Thu Nov 10 2022 - 09:10:57 EST


Andrew Lunn <andrew@xxxxxxx> wrote:

> > +#ifdef CONFIG_AF_RXRPC_IPV6
> > return ipv6_icmp_error(sk, skb, err, port, info, payload);
> > +#endif
>
> Can this be if (IS_ENABLED(CONFIG_AF_RXRPC_IPV6) {} rather than
> #ifdef? It gives better build testing.

Sure. Does it actually make that much of a difference? I guess the
declaration is there even if IPV6 is disabled.

David