Re: [PATCH v1] net: macvlan: Use built-in RCU list checking

[Chuang W]

Hi,

On Thu, Nov 10, 2022 at 6:57 PM Paolo Abeni <pabeni@xxxxxxxxxx> wrote:
>
> Hello,
>
> On Tue, 2022-11-08 at 20:52 +0800, Chuang Wang wrote:
> > hlist_for_each_entry_rcu() has built-in RCU and lock checking.
> >
> > Pass cond argument to hlist_for_each_entry_rcu() to silence false
> > lockdep warning when CONFIG_PROVE_RCU_LIST is enabled.
> >
> > Execute as follow:
> >
> >  ip link add link eth0 type macvlan mode source macaddr add <MAC-ADDR>
> >
> > The rtnl_lock is held when macvlan_hash_lookup_source() or
> > macvlan_fill_info_macaddr() are called in the non-RCU read side section.
> > So, pass lockdep_rtnl_is_held() to silence false lockdep warning.
> >
> > Signed-off-by: Chuang Wang <nashuiliang@xxxxxxxxx>
>
> The patch LGTM, but IMHO this should target the -net tree, as it's
> addressing an issue bothering people.

Sorry, can I sincerely ask if the -net tree is
git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git or
git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git ?

>
> Can you please re-submit, specifying the target tree into the subj and
> including a suitable Fixes tag?

ok, I will add a suitable Fixed tag and resubmit. Thanks.

>
> Thanks!
>
> Paolo
>
>