Re: [PATCH 2/3] media: dt-bindings: media: mediatek: vcodec: Change the max reg value to 2

From: Yunfei Dong (董云飞)
Date: Thu Nov 10 2022 - 05:34:35 EST


Dear AngeloGioacchino Del,

Thank for your suggestion, looks very reasonable.
Fix in v2.

Best regards,
Yunfei Dong

On Wed, 2022-11-09 at 10:29 +0100, AngeloGioacchino Del Regno wrote:
> Il 09/11/22 08:35, Yunfei Dong ha scritto:
> > Need to add racing control register base in device node for mt8195
> > support
> > inner racing mode. Changing the max reg value from 1 to 2.
> >
> > Signed-off-by: Yunfei Dong <yunfei.dong@xxxxxxxxxxxx>
> > ---
> > .../bindings/media/mediatek,vcodec-subdev-decoder.yaml |
> > 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> > decoder.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,vcodec-subdev-
> > decoder.yaml
> > index 794012853834..1697feb1f854 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > subdev-decoder.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-
> > subdev-decoder.yaml
> > @@ -61,7 +61,7 @@ properties:
> > - mediatek,mt8195-vcodec-dec
> >
> > reg:
> > - maxItems: 1
> > + maxItems: 2
>
> What about doing, instead...
>
> - description: VDEC_SYS register space
> - description: VDEC_RACING_CTRL register space
>
> then, setting `minItems: 1` will make the racing_ctrl iospace
> optional :-)
>
> Regards,
> Angelo
>
>