Re: [PATCH v2 1/6] pwm: Add a stub for devm_pwmchip_add()

From: Andy Shevchenko
Date: Thu Nov 10 2022 - 04:55:28 EST


On Thu, Nov 10, 2022 at 9:07 AM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
> On Tue, Nov 08, 2022 at 04:22:21PM +0200, Andy Shevchenko wrote:

...

> > +static inline int devm_pwmchip_add(struct device *dev, struct pwm_chip *chip)
> > +{
> > + return -EINVAL;
> > +}
> > +
>
> I'm a bit surprised to see this returning -EINVAL and not -ENOSYS. But
> that's in line with the other stubs, so:

Exactly my thoughts when I created such a change.

> Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Thank you!

--
With Best Regards,
Andy Shevchenko