Re: [PATCH v2 3/3] ARM: dts: qcom-msm8960-cdp: align TLMM pin configuration with DT schema

[Krzysztof Kozlowski]

On 10/11/2022 04:37, Bjorn Andersson wrote:
> On Wed, Nov 09, 2022 at 11:51:40AM +0100, Krzysztof Kozlowski wrote:
>> DT schema expects TLMM pin configuration nodes to be named with
>> '-state' suffix and their optional children with '-pins' suffix.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>>
>> ---
>>
>> Changes since v1:
>> 1. Add Rb tag
>> ---
>>  arch/arm/boot/dts/qcom-msm8960-cdp.dts | 19 +++++++++----------
>>  1 file changed, 9 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom-msm8960-cdp.dts b/arch/arm/boot/dts/qcom-msm8960-cdp.dts
>> index 3a484ac53917..9a3a510f88ca 100644
>> --- a/arch/arm/boot/dts/qcom-msm8960-cdp.dts
>> +++ b/arch/arm/boot/dts/qcom-msm8960-cdp.dts
>> @@ -60,33 +60,32 @@ &gsbi5_serial {
>>  };
>>  
>>  &msmgpio {
>> -	spi1_default: spi1_default {
>> -		 mux {
>> -			pins = "gpio6", "gpio7", "gpio9";
>> -			function = "gsbi1";
>> -		 };
>> -
>> -		 mosi {
>> +	spi1_default: spi1-default-state {
>> +		 mosi-pins {
>>  			pins = "gpio6";
>> +			function = "gsbi1";
>>  			drive-strength = <12>;
>>  			bias-disable;
>>  		 };
>>  
>> -		 miso {
>> +		 miso-pins {
>>  			pins = "gpio7";
>> +			function = "gsbi1";
>>  			drive-strength = <12>;
>>  			bias-disable;
>>  		 };
>>  
>> -		 cs {
>> +		 cs-pins {
>>  			pins = "gpio8";
>> +			function = "gpio";
> 
> I'm changing this to "gsbi1" while applying this patch.

Thanks Bjorn. This was missing in original DTS, so I assumed intention
was a GPIO-based CS. I guess SPI-based also makes sense...

Best regards,
Krzysztof