Re: [PATCH v2 4/6] pwm: lpss: Allow other drivers to enable PWM LPSS

From: Uwe Kleine-König
Date: Thu Nov 10 2022 - 02:35:29 EST


On Thu, Nov 10, 2022 at 08:28:10AM +0100, Uwe Kleine-König wrote:
> On Tue, Nov 08, 2022 at 04:22:24PM +0200, Andy Shevchenko wrote:
> > The PWM LPSS device can be embedded in another device.
> > In order to enable it, allow that drivers to probe
> > a corresponding device.
>
> "probe" isn't the right term here. The other driver only creates the
> device.

Ah, I didn't look carefully enough for this judgement. My (wrong)
expectation was, that the containing device creates a platform-device
with .parent=$self and then drivers/pwm/pwm-lpss-platform.c does all the
necessary stuff automatically.

Hmm, I can live with that, so I drop this concern.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature