Re: [PATCH] module: Fix NULL vs IS_ERR checking for module_get_next_page

From: Luis Chamberlain
Date: Wed Nov 09 2022 - 23:09:23 EST


On Thu, Nov 10, 2022 at 06:58:34AM +0400, Miaoqian Lin wrote:
> The module_get_next_page() function return error pointers on error
> instead of NULL.
> Use IS_ERR() to check the return value to fix this.
>
> Fixes: b1ae6dc41eaa ("module: add in-kernel support for decompressing")
> Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
> ---

Thanks queued up. How did you find out? Just code inspection? I see
chances are low of this triggering, but just curious how you found it.

Luis