Re: [PATCH 1/2] bfq: fix waker_bfqq inconsistency crash

From: Jens Axboe
Date: Wed Nov 09 2022 - 14:48:09 EST


On Tue, 8 Nov 2022 10:10:29 -0800, Khazhismel Kumykov wrote:
> This fixes crashes in bfq_add_bfqq_busy due to waker_bfqq being NULL,
> but woken_list_node still being hashed. This would happen when
> bfq_init_rq() expects a brand new allocated queue to be returned from
> bfq_get_bfqq_handle_split() and unconditionally updates waker_bfqq
> without resetting woken_list_node. Since we can always return oom_bfqq
> when attempting to allocate, we cannot assume waker_bfqq starts as NULL.
>
> [...]

Applied, thanks!

[1/2] bfq: fix waker_bfqq inconsistency crash
commit: a1795c2ccb1e4c49220d2a0d381540024d71647c
[2/2] bfq: ignore oom_bfqq in bfq_check_waker
commit: 99771d73ff4539f2337b84917f4792abf0d8931b

Best regards,
--
Jens Axboe