Re: [PATCH 4/6] KVM: selftests: Make Hyper-V guest OS ID common

From: Vipin Sharma
Date: Wed Nov 09 2022 - 13:54:02 EST


On Wed, Nov 9, 2022 at 5:48 AM Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> wrote:
>
> Vipin Sharma <vipinsh@xxxxxxxxxx> writes:
>
> > Make guest OS ID calculation common to all hyperv tests and similar to
> > hv_generate_guest_id().
>
> A similar (but without hv_linux_guest_id()) patch is present in my
> Hyper-V TLB flush update:
>
> https://lore.kernel.org/kvm/20221101145426.251680-32-vkuznets@xxxxxxxxxx/
>

After getting feedback from David, I decided to remove
LINUX_VERSION_CODE in v2. Our patches are functionally identical now.

@Sean, Paolo, Vitaly
Should I be rebasing my v2 on top of TLB flush patch series and remove
patch 4 and 5 from my series? I am not sure how these situations are
handled.

@Vitaly
Are you planning to send v14?

If yes, then for v13 Patch 31 (KVM: selftests: Move HYPERV_LINUX_OS_ID
definition to a common header) will you keep it same or will you
modify it to add HYPERV_LINUX_OS_ID in hyperv_clock.c and
hyperv_svm_test.c?

If not, then I can add a patch in my series to change those two files
if I end up rebasing on top of your series.