Re: [PATCH V3 2/2] arm64: dts: qcom: sc7280: Add Google Herobrine WIFI SKU dts fragment

[Doug Anderson]

Hi,

On Tue, Nov 8, 2022 at 9:52 PM Sibi Sankar <quic_sibis@xxxxxxxxxxx> wrote:
>
> The Google Herobrine WIFI SKU can save 256M by not having modem/mba/rmtfs
> memory regions defined. Add the dts fragment and mark all the board files
> appropriately.
>
> Signed-off-by: Sibi Sankar <quic_sibis@xxxxxxxxxxx>
> ---
>
> v2:
>  * Mark the WIFI SKUs of Evoker/Villager-r1
>  * Misc. Fixes [Doug]
>
> Instead of just having remoteproc_mpss node disabled, we go ahead and
> delete it on wifi only SKUs. This is done to avoid the dtbs_check
> failures that we would end of getting if we delete the memory-region
> property present in the node (since it's a required property). I'll
> send a follow up patch with IPA node enabled only on LTE SKUs as soon
> as I verify that it doesn't have any impact on suspend/resume.
>
>  .../boot/dts/qcom/sc7280-chrome-common.dtsi   | 15 --------
>  .../dts/qcom/sc7280-herobrine-evoker-lte.dts  |  4 +-
>  .../boot/dts/qcom/sc7280-herobrine-evoker.dts |  2 +-
>  .../dts/qcom/sc7280-herobrine-evoker.dtsi     |  1 +
>  .../dts/qcom/sc7280-herobrine-lte-sku.dtsi    | 19 ++++++++++
>  .../qcom/sc7280-herobrine-villager-r1-lte.dts |  4 +-
>  .../dts/qcom/sc7280-herobrine-villager-r1.dts | 31 +---------------
>  .../qcom/sc7280-herobrine-villager-r1.dtsi    | 37 +++++++++++++++++++
>  .../dts/qcom/sc7280-herobrine-wifi-sku.dtsi   | 11 ++++++
>  9 files changed, 77 insertions(+), 47 deletions(-)
>  create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dtsi
>  create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-wifi-sku.dtsi

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>