Re: [PATCH 1/5] ARM: dts: nanobone: Fix GPIO settings for RTS/CTS pins on UART3 & 4

From: Mark Jackson
Date: Wed Nov 09 2022 - 12:04:37 EST


On Wed, 9 Nov 2022 at 16:58, Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 09/11/2022 17:57, Mark Jackson wrote:
> > On Wed, 9 Nov 2022 at 16:22, Krzysztof Kozlowski
> > <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> >>
> >> On 09/11/2022 17:09, Mark Jackson wrote:
> >>> The NanoBone platform uses GPIO pins for RTS/CTS control.
> >>> The DTS still uses the hardware RTS/CTS pins so this needs fixing.
> >>>
> >>> Signed-off-by: Mark Jackson <mpfj@xxxxxxxxxxxxx>
> >>> ---
> >>> arch/arm/boot/dts/am335x-nano.dts | 8 ++++----
> >>
> >> You still use a bit odd subject prefixes. What did the log tell you for
> >> am335x files?
> >
> > Aha, now I understand ... I need to change "nanobone" in the title to
> > "am335x-nano" to match our dts file, correct ?
>
> Yes, I think this is the most popular subject prefix. It allows
> sub-architecture maintainers to understand what is it about.

Seems reasonable ... I was almost correct with my first attempt.
I'll send myself off for re-training ...

Cheers
Mark J.