Re: [PATCH printk v3 11/40] um: kmsg_dumper: use srcu console list iterator

From: Petr Mladek
Date: Wed Nov 09 2022 - 10:05:12 EST


On Mon 2022-11-07 15:22:09, John Ogness wrote:
> Rather than using the console_lock to guarantee safe console list
> traversal, use srcu console list iteration.

It might be obvious. But I would add:

"It allows to dump the messages even when console_lock() is blocked
during panic()."

It will help to understand this is a clear win.

> Signed-off-by: John Ogness <john.ogness@xxxxxxxxxxxxx>

After merging with 9th patch for using the racy console_is_enabled(con):

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr