Re: [PATCH 1/2] dt-bindings: clock: add QCOM SM6375 display clock bindings

[Krzysztof Kozlowski]

On 09/11/2022 15:18, Konrad Dybcio wrote:
> Add device tree bindings for display clock controller for
> Qualcomm Technology Inc's SM6375 SoC.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Cool! Welcome!

> ---
>  .../bindings/clock/qcom,sm6375-dispcc.yaml    | 68 +++++++++++++++++++
>  .../dt-bindings/clock/qcom,sm6375-dispcc.h    | 42 ++++++++++++
>  2 files changed, 110 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm6375-dispcc.yaml
>  create mode 100644 include/dt-bindings/clock/qcom,sm6375-dispcc.h
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm6375-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm6375-dispcc.yaml
> new file mode 100644
> index 000000000000..4f905f0bc1d9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm6375-dispcc.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: GPL-2.0-only

Dual license, please, unless you include here some stuff which prevents it.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,sm6375-dispcc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Display Clock & Reset Controller Binding for SM6375

Adjust it to match style-refactoring:
https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=clk-for-6.2&id=ece3c3198182a13825a7f02844894ba6a03d58d1

> +
> +maintainers:
> +  - Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> +
> +description: |
> +  Qualcomm display clock control module which supports the clocks, resets and
> +  power domains on SM6375.

Also here

> +
> +  See also:
> +  - dt-bindings/clock/qcom,dispcc-sm6375.h

And here

> +
> +properties:
> +  compatible:
> +    const: qcom,sm6375-dispcc
> +
> +  clocks:
> +    items:
> +      - description: Board XO source
> +      - description: GPLL0 source from GCC
> +      - description: Byte clock from DSI PHY
> +      - description: Pixel clock from DSI PHY
> +
> +  '#clock-cells':
> +    const: 1
> +
> +  '#reset-cells':
> +    const: 1
> +
> +  '#power-domain-cells':
> +    const: 1

All these look like qcom,gcc.yaml

https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=clk-for-6.2&id=842b4ca1cb8cf547dc63cfe37342f0704454ac2f

> +
> +  reg:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - '#clock-cells'
> +  - '#reset-cells'
> +  - '#power-domain-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/qcom,sm6375-gcc.h>
> +    #include <dt-bindings/clock/qcom,rpmh.h>
> +
> +    clock-controller@5f00000 {
> +      compatible = "qcom,sm6375-dispcc";
> +      reg = <0x05f00000 0x20000>;
> +      clocks = <&rpmhcc RPMH_CXO_CLK>,
> +               <&gcc GCC_DISP_GPLL0_CLK_SRC>,
> +               <&dsi_phy 0>,
> +               <&dsi_phy 1>;
> +      #clock-cells = <1>;
> +      #reset-cells = <1>;
> +      #power-domain-cells = <1>;
> +    };
> +...
> diff --git a/include/dt-bindings/clock/qcom,sm6375-dispcc.h b/include/dt-bindings/clock/qcom,sm6375-dispcc.h
> new file mode 100644
> index 000000000000..b1de14677a61
> --- /dev/null
> +++ b/include/dt-bindings/clock/qcom,sm6375-dispcc.h
> @@ -0,0 +1,42 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */

Dual license


Best regards,
Krzysztof