Re: [PATCH 1/2] driver core: remove devm_device_remove_groups()

[Rafael J. Wysocki]

On Wed, Nov 9, 2022 at 3:07 PM Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> There is no in-kernel user of this function, so it is not needed anymore
> and can be removed.
>
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

For both patches in the series:

Reviewed-by: Rafael J. Wysocki <rafael@xxxxxxxxxx>

> ---
>  drivers/base/core.c    | 17 -----------------
>  include/linux/device.h |  2 --
>  2 files changed, 19 deletions(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index d02501933467..6137de5073b1 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -2693,23 +2693,6 @@ int devm_device_add_groups(struct device *dev,
>  }
>  EXPORT_SYMBOL_GPL(devm_device_add_groups);
>
> -/**
> - * devm_device_remove_groups - remove a list of managed groups
> - *
> - * @dev:       The device for the groups to be removed from
> - * @groups:    NULL terminated list of groups to be removed
> - *
> - * If groups is not NULL, remove the specified groups from the device.
> - */
> -void devm_device_remove_groups(struct device *dev,
> -                              const struct attribute_group **groups)
> -{
> -       WARN_ON(devres_release(dev, devm_attr_groups_remove,
> -                              devm_attr_group_match,
> -                              /* cast away const */ (void *)groups));
> -}
> -EXPORT_SYMBOL_GPL(devm_device_remove_groups);
> -
>  static int device_add_attrs(struct device *dev)
>  {
>         struct class *class = dev->class;
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 023ea50b1916..4efc607c008c 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -1062,8 +1062,6 @@ static inline void device_remove_group(struct device *dev,
>
>  int __must_check devm_device_add_groups(struct device *dev,
>                                         const struct attribute_group **groups);
> -void devm_device_remove_groups(struct device *dev,
> -                              const struct attribute_group **groups);
>  int __must_check devm_device_add_group(struct device *dev,
>                                        const struct attribute_group *grp);
>  void devm_device_remove_group(struct device *dev,
> --
> 2.38.1
>