Re: [PATCH v1 1/2] resource: Replace printk(KERN_WARNING) by pr_warn()

From: Greg Kroah-Hartman
Date: Wed Nov 09 2022 - 08:37:09 EST


On Wed, Nov 09, 2022 at 01:26:47PM +0200, Andy Shevchenko wrote:
> On Wed, Nov 09, 2022 at 12:12:03PM +0100, Rafael J. Wysocki wrote:
> > On Wed, Nov 9, 2022 at 11:51 AM Andy Shevchenko
> > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > >
> > > Replace printk(KERN_WARNING) by pr_warn().
> > >
> > > While at it, use %pa for the resource_size_t variables.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> >
> > This is Greg's stuff I think.
>
> OK.
>
> ...
>
> > > + resource_size_t end = addr + size - 1;
> >
> > And this change could be mentioned in the changelog too.
>
> And it's (indirectly). This is to have a variable to be consistent in the
> print. But I can add more explicit mention.

Please do.