Re: [PATCH 4/4] mmc: f-sdh30: Add compatible string for Socionext F_SDH30_E51

[Kunihiko Hayashi]

Hi Jassi-san,

On 2022/11/09 1:03, Jassi Brar wrote:
> On Tue, 8 Nov 2022 at 02:25, Kunihiko Hayashi
> <hayashi.kunihiko@xxxxxxxxxxxxx> wrote:
> ....
> > @@ -228,6 +229,7 @@ static int sdhci_f_sdh30_remove(struct platform_device
> > *pdev)
> >   #ifdef CONFIG_OF
> >   static const struct of_device_id f_sdh30_dt_ids[] = {
> >          { .compatible = "fujitsu,mb86s70-sdhci-3.0" },
> > +       { .compatible = "socionext,f-sdh30-e51-mmc" },
> This also needs to be specified in the dt bindings, not just in the driver.
> And if this patchset is for the "e51-mmc" type controller, introduce
> the compatible first and apply the changes for that controller.

I understand.
I need to confirm if the extend operations in this patch depend on
new F_SDH30_E51 or common with original F_SDH30.


> > @@ -258,4 +260,5 @@ module_platform_driver(sdhci_f_sdh30_driver);
> >   MODULE_DESCRIPTION("F_SDH30 SD Card Controller driver");
> >   MODULE_LICENSE("GPL v2");
> >   MODULE_AUTHOR("FUJITSU SEMICONDUCTOR LTD.");
> > +MODULE_AUTHOR("Socionext Inc.");
> Socionext now is what Fujitsu was when this code was written, so this
> addition seems ok.
> So may be add it as
>      MODULE_AUTHOR("FUJITSU SEMICONDUCTOR LTD., SOCIONEXT INC.");
Although I'm confused how to write this, I'll write it that way.

Thank you,

---
Best Regards
Kunihiko Hayashi