Re: [PATCH] x86/paravirt: use common macro for creating simple asm paravirt functions

[Juergen Gross]

On 09.11.22 06:16, Srivatsa S. Bhat wrote:
> Hi Juergen,
>
> Sorry for the delay in reviewing this patch!
>
> On 10/20/22 2:19 AM, Juergen Gross wrote:
> > There are some paravirt assembler functions which are sharing a common
> > pattern. Introduce a macro DEFINE_PARAVIRT_ASM() for creating them.
> >
> > The explicit _paravirt_nop() prototype in paravirt.c isn't needed, as
> > it is included in paravirt_types.h already.
> >
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>
> I just wanted to make a note that the part of this patch that's not
> purely cleanup is the addition of the alignment (__ALIGN_STR) to
> __raw_callee_save___kvm_vcpu_is_preempted(), _paravirt_nop() and
> paravirt_ret0(). Maybe that's worth calling out in the commit message?

I can do that.

> Reviewed-by: Srivatsa S. Bhat (VMware) <srivatsa@xxxxxxxxxxxxx>

Thanks,


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature