RE: [PATCH net 1/1] net: phy: dp83867: Fix SGMII FIFO depth for non OF devices

From: Sit, Michael Wei Hong
Date: Tue Nov 08 2022 - 21:20:36 EST




> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Wednesday, November 9, 2022 9:56 AM
> To: Sit, Michael Wei Hong <michael.wei.hong.sit@xxxxxxxxx>
> Cc: Andrew Lunn <andrew@xxxxxxx>; Heiner Kallweit
> <hkallweit1@xxxxxxxxx>; Russell King <linux@xxxxxxxxxxxxxxx>;
> David S . Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
> <edumazet@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Looi,
> Hong Aun <hong.aun.looi@xxxxxxxxx>; Voon, Weifeng
> <weifeng.voon@xxxxxxxxx>; Tan, Tee Min
> <tee.min.tan@xxxxxxxxx>; Zulkifli, Muhammad Husaini
> <muhammad.husaini.zulkifli@xxxxxxxxx>; Gan, Yi Fang
> <yi.fang.gan@xxxxxxxxx>
> Subject: Re: [PATCH net 1/1] net: phy: dp83867: Fix SGMII FIFO
> depth for non OF devices
>
> On Tue, 8 Nov 2022 18:12:18 +0800 Michael Sit Wei Hong wrote:
> > Current driver code will read device tree node information, and
> set
> > default values if there is no info provided.
> >
> > This is not done in non-OF devices leading to SGMII fifo depths
> being
> > set to the smallest size.
> >
> > This patch sets the value to the default value of the PHY as
> stated in
> > the PHY datasheet.
>
> We need a Fixes tag, which commit should have contained this
> code?

Will add the Fixes tag in the next revision.
Thanks.