Re: [PATCH v2 08/18] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis

From: Krzysztof Kozlowski
Date: Tue Nov 08 2022 - 16:19:10 EST


On 08/11/2022 00:56, Bryan O'Donoghue wrote:
> Each compatible has a different set of clocks which are associated with it.
> Add in the list of clocks for each compatible.
>
> Cc: Rob Clark <robdclark@xxxxxxxxx>
> Cc: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> Cc: Sean Paul <sean@xxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> Cc: linux-arm-msm@xxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: freedreno@xxxxxxxxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---
> .../display/msm/dsi-controller-main.yaml | 177 +++++++++++++++---
> 1 file changed, 150 insertions(+), 27 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> index 9db3e63acda3d..c975df0ca22fc 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
> @@ -9,24 +9,22 @@ title: Qualcomm Display DSI controller
> maintainers:
> - Krishna Manikandan <quic_mkrishn@xxxxxxxxxxx>
>
> -allOf:
> - - $ref: "../dsi-controller.yaml#"
> -
> properties:
> compatible:
> - enum:
> - - qcom,dsi-ctrl-6g-qcm2290
> - - qcom,mdss-dsi-ctrl
> - - qcom,mdss-dsi-ctrl-apq8064
> - - qcom,mdss-dsi-ctrl-msm8916
> - - qcom,mdss-dsi-ctrl-msm8974
> - - qcom,mdss-dsi-ctrl-msm8996
> - - qcom,mdss-dsi-ctrl-sc7180
> - - qcom,mdss-dsi-ctrl-sc7280
> - - qcom,mdss-dsi-ctrl-sdm630
> - - qcom,mdss-dsi-ctrl-sdm660
> - - qcom,mdss-dsi-ctrl-sdm845
> - - qcom,mdss-dsi-ctrl-sm8250
> + items:
> + - enum:
> + - qcom,dsi-ctrl-6g-qcm2290
> + - qcom,mdss-dsi-ctrl-apq8064
> + - qcom,mdss-dsi-ctrl-msm8916
> + - qcom,mdss-dsi-ctrl-msm8974
> + - qcom,mdss-dsi-ctrl-msm8996
> + - qcom,mdss-dsi-ctrl-sc7180
> + - qcom,mdss-dsi-ctrl-sc7280
> + - qcom,mdss-dsi-ctrl-sdm630
> + - qcom,mdss-dsi-ctrl-sdm660
> + - qcom,mdss-dsi-ctrl-sdm845
> + - qcom,mdss-dsi-ctrl-sm8250
> + - const: qcom,mdss-dsi-ctrl

This is not explained in commit msg and looks like part of previous commit.


Best regards,
Krzysztof