Re: [PATCH 5.10 000/118] 5.10.154-rc1 review

[Pavel Machek]

Hi!

> > > This is the start of the stable review cycle for the 5.10.154 release.
> > > There are 118 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > 
> > I'm getting build errors with the dtbs:
> > 
> > Error: arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi:1296.24-25 syntax error
> > 10169FATAL ERROR: Unable to parse input tree
> > 10170make[2]: *** [scripts/Makefile.lib:326: arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb] Error 1
> > 10171make[2]: *** Waiting for unfinished jobs....
> > 10172Error: arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi:1296.24-25 syntax error
> > 10173FATAL ERROR: Unable to parse input tree
> > 10174make[2]: *** [scripts/Makefile.lib:326: arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb] Error 1
> > 10175  DTC     arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2.dtb
> > 10176  DTC     arch/arm64/boot/dts/allwinner/sun50i-h5-bananapi-m2-plus-v1.2.dtb
> > 10177  DTC     arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2-ex.dtb
> > 10178Error: arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi:1296.24-25 syntax error
> > 10179FATAL ERROR: Unable to parse input tree
> > 10180make[2]: *** [scripts/Makefile.lib:326: arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dtb] Error 1
> > 10181  DTC     arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dtb
> > 10182
> > 
> > https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/3291098692
> 
> Odd.
> 
> Sasha, any ideas what went wrong here, but not in the other
> branches?

I believe it is this commit:

 |4f9355148 c126a0 .: 5.10| arm64: dts: lx2160a: specify clock frequencies for the MDIO controllers

pavel@duo:~/cip/krc$ grep -ri QORIQ_CLK_PLL_DIV .
./arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi:					    QORIQ_CLK_PLL_DIV(2)>;
./arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi:					    QORIQ_CLK_PLL_DIV(2)>;
pavel@duo:~/cip/krc$ 

The macro QORIQ_CLK_PLL_DIV is not defined in 5.10, so it confuses
parser. I guess it should be dropped, or dependencies should be added.

We need this:

include/dt-bindings/clock/fsl,qoriq-clockgen.h:#define QORIQ_CLK_PLL_DIV(x)     ((x) - 1)

Which was added in commit 4cb15934ba05b49784d9d47778af308e7ea50b69 to
mainline. That's not only dependency. 

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: PGP signature