Re: [PATCH v2 2/2] arm64: dts: ti: Add support for phyBOARD-Electra-AM642

[Krzysztof Kozlowski]

On 08/11/2022 19:25, Wadim Egorov wrote:
> 
>>> +	leds {
>>> +		compatible = "gpio-leds";
>>> +		pinctrl-names = "default";
>>> +		pinctrl-0 = <&user_leds_pins_default>;
>>> +
>>> +		led-1 {
>>> +			color = <LED_COLOR_ID_RED>;
>>> +			gpios = <&main_gpio0 15 GPIO_ACTIVE_HIGH>;
>>> +			linux,default-trigger = "mmc0";
>>> +			function = LED_FUNCTION_DISK;
>>> +		};
>>> +
>>> +		led-2 {
>>> +			color = <LED_COLOR_ID_GREEN>;
>>> +			gpios = <&main_gpio0 16 GPIO_ACTIVE_HIGH>;
>>> +			linux,default-trigger = "mmc1";
>>> +			function = LED_FUNCTION_DISK;
>>> +		};
>>> +	};
>>> +
>>> +	vcc_3v3_mmc: regulator-sd {
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my
>> feedback got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all
>> requested changes or keep discussing them.
> 
> But what is wrong with the "regulator-sd" node name?

Uh, you are right, this is correct, my eyes are playing tricks on me...

Best regards,
Krzysztof