Re: [PATCH 1/2] staging: rtl8723bs: Simplify underutilized 2D array to 1D array

From: Deepak R Varma
Date: Tue Nov 08 2022 - 12:50:12 EST


On Tue, Nov 08, 2022 at 04:19:41PM +0100, Greg Kroah-Hartman wrote:
> On Sat, Nov 05, 2022 at 02:47:49PM +0530, Deepak R Varma wrote:
> > On Sat, Nov 05, 2022 at 02:14:12PM +0530, Deepak R Varma wrote:
> > Hello Greg,
> > Upon further review of the structure, I observed that the member "bIQKDone" is
> > also not used anywhere in the code and it can be removed as well. That cleanup
> > will lead to replacing this entire structure by a simple one dimensional 'Value"
> > array.
> >
> > Please suggest if I should make that change and send in a revision?
>
> Yes, that would be a better overall change.

Hello Greg,
The patch is resubmitted earlier with following subject:
[PATCH v2] staging: rtl8723bs: replace underutilized struct by array variable

Thank you,
./drv

>
> thanks,
>
> greg k-h
>