Re: [PATCH v10 05/16] riscv: Add has_vector/riscv_vsize to save vector features.

[Vineet Gupta]

On 5/15/22 23:47, Christoph Hellwig wrote:
> On Wed, May 11, 2022 at 08:31:15AM +0000, Greentime Hu wrote:
> > +#ifdef CONFIG_VECTOR
> > +#include <asm/vector.h>
> > +EXPORT_SYMBOL(rvv_enable);
> > +EXPORT_SYMBOL(rvv_disable);
> > +#endif
>
> As far as I can tell these are not used by any modular code, just by
> the later added kernel mode vector enable helpers.
>
> Even if they were used this would need to be EXPORT_SYMBOL_GPL.

In the new version, I've made them static inline given the size and 
frequency of them being called. So this becomes moot.

> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * Copyright (C) 2012 Regents of the University of California
> > + * Copyright (C) 2017 SiFive
> > + * Copyright (C) 2019 Alibaba Group Holding Limited
> > + *
> > + *   This program is free software; you can redistribute it and/or
> > + *   modify it under the terms of the GNU General Public License
> > + *   as published by the Free Software Foundation, version 2.
> > + *
> > + *   This program is distributed in the hope that it will be useful,
> > + *   but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + *   GNU General Public License for more details.
> > + */
>
> No need for all the GPL boilerplate text when you have an SPDX tag.

OK.