Re: [PATCH net-next 1/1] net: phy: dp83867: add TI PHY loopback

[Andrew Lunn]

On Tue, Nov 08, 2022 at 06:15:27PM +0800, Michael Sit Wei Hong wrote:
> From: Tan Tee Min <tee.min.tan@xxxxxxxxxxxxxxx>
> 
> The existing genphy_loopback() is not working for TI DP83867 PHY as it
> will disable autoneg support while another side is still enabling autoneg.
> This is causing the link is not established and results in timeout error
> in genphy_loopback() function.
> 
> Thus, based on TI PHY datasheet, introduce a TI PHY loopback function by
> just configuring BMCR_LOOPBACK(Bit-9) in MII_BMCR register (0x0).
> 
> Tested working on TI DP83867 PHY for all speeds (10/100/1000Mbps).
> 
> Signed-off-by: Tan Tee Min <tee.min.tan@xxxxxxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew