Re: [PATCH 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs

From: Linus Walleij
Date: Tue Nov 08 2022 - 07:31:34 EST


Hi Chester,

thanks for your patch!

On Mon, Oct 31, 2022 at 11:09 AM Chester Lin <clin@xxxxxxxx> wrote:

> Add DT schema for the pinctrl driver of NXP S32 SoC family.
>
> Signed-off-by: Larisa Grigore <larisa.grigore@xxxxxxx>
> Signed-off-by: Ghennadi Procopciuc <Ghennadi.Procopciuc@xxxxxxx>
> Signed-off-by: Chester Lin <clin@xxxxxxxx>
(...)
> + nxp,pins:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description:
> + A list of [start, end] pin ID boundaries that correspond to each of
> + the register regions reserved.

That's an interesting approach.

But what about just hardcoding this into the driver instead?

If you have the compatible, surely you know these indexes from
that compatible string?

Yours,
Linus Walleij