Re: [PATCH v2 5/5] arm64: dts: uniphier: Add NX1 SoC and boards support

[Krzysztof Kozlowski]

On 07/11/2022 11:34, Kunihiko Hayashi wrote:
> Initial version of devicetree sources for NX1 SoC and boards.
> 
> NX1 SoC belongs to the UniPhier armv8 architecture platform, and is
> designed for IoT and AI/ML application fields.
> 

> +
> +		soc_glue: syscon@1f800000 {
> +			compatible = "socionext,uniphier-nx1-soc-glue",
> +				     "simple-mfd", "syscon";
> +			reg = <0x1f800000 0x2000>;
> +
> +			pinctrl: pinctrl {
> +				compatible = "socionext,uniphier-nx1-pinctrl";

So instead of documenting the hardware precisily, you have one big bag
for everything under simple-mfd. This is not how the SoC should be
described in DTS.

> +			};
> +		};
> +
> +		soc-glue@1f900000 {
> +			compatible = "simple-mfd";

No, it is not allowed on its own. You need a specific compatible and
bindings describing its children.


Best regards,
Krzysztof