Re: [PATCH 08/14] net: vlan: remove invalid VLAN protocol warning

From: Felix Fietkau
Date: Tue Nov 08 2022 - 05:57:10 EST


On 08.11.22 11:52, Vladimir Oltean wrote:
On Tue, Nov 08, 2022 at 11:42:09AM +0100, Felix Fietkau wrote:
Okay, I will stick with METADATA_HW_PORT_MUX for now. If we use it in the
flow dissector to avoid the tagger specific fixup, we might as well use it
in DSA to skip the tag proto receive call. What do you think?

I suppose that dsa_switch_rcv() could test for the presence of a metadata_dst
and treat that generically if present, without unnecessarily calling down into
the tagging protocol ->rcv() call. The assumption being that the metadata_dst
is always formatted (by the DSA master) in a vendor-agnostic way.
Right. The assumption is that if we use METADATA_HW_PORT_MUX, the field md_dst->u.port_info.port_id will contain the index of the DSA port.

- Felix