Re: [PATCH 2/3] x86/speculation: Support Automatic IBRS

From: Peter Zijlstra
Date: Tue Nov 08 2022 - 03:09:13 EST


On Mon, Nov 07, 2022 at 03:41:03PM -0800, Dave Hansen wrote:
> On 11/7/22 14:39, Kim Phillips wrote:
> > I've started a version that has AUTOIBRS reuse SPECTRE_V2_EIBRS
> > spectre_v2_mitigation enum, but, so far, it's change to bugs.c
> > looks bigger: 58 lines changed vs. 34 (see below).
> >
> > Let me know if you want me to send it as a part of a v2 submission
> > after I take care of the kvm CPUID review.
>
> Thanks for putting that together. I generally like how this looks.
>
> I think it probably goes to a _bit_ too much trouble to turn off
> "eibrs,lfence/retpoline". If someone goes to the trouble of specifying
> those, a warning or pr_info() is probably enough. You don't need to
> actively override it.

Not, even, just do it. User told you to, it's not technically
impossible, so just go.