Re: [RFC PATCH 3/4] io_uring/splice: support splice from ->splice_read to ->splice_read

From: Christoph Hellwig
Date: Tue Nov 08 2022 - 02:45:36 EST


On Thu, Nov 03, 2022 at 04:50:03PM +0800, Ming Lei wrote:
> The 1st ->splice_read produces buffer to the pipe of
> current->splice_pipe, and the 2nd ->splice_read consumes the buffer
> in this pipe.

This looks really ugly. I think you want Linus and Al to look over
it at very least.

Also, what is going to happen if your ->splice_read instance does not
support the flag to magically do something entirely different?