Re: [PATCH] scsi: lpfc: remove redundant pointer lp
From: Martin K. Petersen
Date: Mon Nov 07 2022 - 22:47:21 EST
Colin,
> Pointer lp is being initialized and incremented but the result
> is never read. The pointer is redundant and can be removed.
> @@ -9173,14 +9173,11 @@ lpfc_els_rcv_farpr(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
> struct lpfc_nodelist *ndlp)
Looks like this function has been dubious for a long time. From a quick
glance it doesn't appear to have done anything useful with those
variable assignments since back in the 4.x days.
James, please have a look.
--
Martin K. Petersen Oracle Linux Engineering