Re: [PATCH v1 5/5] rtc: rtc-cmos: Disable ACPI RTC event on removal

From: Andy Shevchenko
Date: Mon Nov 07 2022 - 16:28:48 EST


On Mon, Nov 07, 2022 at 09:03:06PM +0100, Rafael J. Wysocki wrote:

...

> +static inline void acpi_rtc_event_cleanup(void)
> +{
> + if (!acpi_disabled)

Btw, other functions look like using

if (acpi_disabled)
return;

pattern. Maybe here the same for the sake of consistency?

> + acpi_remove_fixed_event_handler(ACPI_EVENT_RTC, rtc_handler);
> +}

--
With Best Regards,
Andy Shevchenko