Re: [PATCH] perf print-events: Remove redundant comparison with zero

[Namhyung Kim]

Hi Minchul,

On Sat, Nov 5, 2022 at 6:59 AM Kang Minchul <tegongkang@xxxxxxxxx> wrote:
>
> Since variable npmus is unsigned int, comparing with 0 is unnecessary.
>
> Signed-off-by: Kang Minchul <tegongkang@xxxxxxxxx>
> ---
>  tools/perf/util/print-events.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/util/print-events.c b/tools/perf/util/print-events.c
> index c4d5d87fae2f..6df947df1c0f 100644
> --- a/tools/perf/util/print-events.c
> +++ b/tools/perf/util/print-events.c
> @@ -311,10 +311,8 @@ int print_hwcache_events(const char *event_glob, bool name_only)
>                                 if ((hybrid_supported == 0) ||
>                                     (hybrid_supported == npmus)) {
>                                         evt_list[evt_i] = strdup(name);
> -                                       if (npmus > 0) {
> -                                               for (j = 0; j < npmus; j++)
> -                                                       zfree(&evt_pmus[j]);
> -                                       }
> +                                       for (j = 0; j < npmus; j++)
> +                                               zfree(&evt_pmus[j]);

You can still have 0 npmus, but then the for loop will not be executed.  So,

Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks,
Namhyung


>                                 } else {
>                                         for (j = 0; j < hybrid_supported; j++) {
>                                                 evt_list[evt_i++] = evt_pmus[j];
> --
> 2.34.1
>